[RDF] Prepare for snapshot with variations (part 4) #19727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 3d 9h 52m 41s ⏱️ For more details on these failures, see this check. Results for commit 2d6683f. ♻️ This comment has been updated with latest results. |
vepadulano
requested changes
Aug 26, 2025
There was a problem hiding this comment.
The last commit LGTM, but since I requested changes in #19726 I will wait for that PR to be merged before continuing
hageboeck
force-pushed
the
snapshot_vary_branchData
branch
2 times, most recently
from
6b2fefe to
9973a55
Compare
hageboeck
force-pushed
the
snapshot_vary_branchData
branch
from
9973a55 to
5afcf96
Compare
In order to implement snapshots with systematic variations, it is beneficial to place all members related to output branches into structs. At present, this only constitutes a move from member of SnapshotHelper to member of RBranchData struct. The TTree snapshot helpers are changed accordingly. Co-authored-by: Vincenzo Eduardo Padulano <[email protected]>
It is superseded by RBranchData.
hageboeck
force-pushed
the
snapshot_vary_branchData
branch
from
5afcf96 to
2d6683f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 4 of the work in #19725.
This PR is a refactor of the members of all TTree snapshot helpers, which will allow keeping all necessary data for a column in a single struct. This will simplify snapshot with variations, since varied columns can be created by copying the struct of the original column, and overriding a few members.
If the data hadn't been colocated like it's done here, it would become much harder to keep everything in a consistent state for both nominal and variations.